Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release to modal e2e env on pr label creation #52

Closed
wants to merge 2 commits into from
Closed

ci: release to modal e2e env on pr label creation #52

wants to merge 2 commits into from

Conversation

sambarnes
Copy link
Collaborator

@sambarnes sambarnes commented Jan 16, 2024 •
edited
Loading

Details

quick one after the momentum of #51 -- starting to lay the foundation for automated integration/e2e testing

largely the same stuff as the other pr, just triggers from an e2e label getting put on someones new pr

todo:

  • inspect repo settings for permissions on who is allowed to add the label
  • create the e2e env in modal
  • actually uh test this out on a pr

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

louisgv
louisgv reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just blocking on:

  1. Setup e2e environment to run this in
  2. Ensure the download script doens't break the whole deployment <- might be a good e2e test case to hammer on

@sambarnes sambarnes closed this Jul 10, 2024
@sambarnes sambarnes deleted the e2e-action.yml branch July 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sambarnes @louisgv